D17691: Add rows info to the plasma virtual desktop protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d1e8b45d9310: Add rows info to the plasma virtual desktop protocol (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=50046&id=50063 REVI

D17691: Add rows info to the plasma virtual desktop protocol

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin, davidedmundson Cc: zzag, davidedmundson, hein, kde-frameworks-devel,

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 50046. mart added a comment. - bump versions REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=49994&id=50046 BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17691 AFFECTED FILES

D17691: Add rows info to the plasma virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > plasmavirtualdesktop_interface.cpp:94 > > const quint32 PlasmaVirtualDesktopManagementInterface::Private::s_version = > 1; > This one should be bumped as well. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 T

D17691: Add rows info to the plasma virtual desktop protocol

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in plasma-virtual-desktop.xml:56 > This isn't done. event needs to be at the end (like how you keep source compatibility in a C++ enum) > plasmavirtualdesktop_interface.cpp:201 > +for (auto it = d->resources.const

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 49994. mart added a comment. - rows belongs to protocol version 2 REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=49610&id=49994 BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17

D17691: Add rows info to the plasma virtual desktop protocol

zzag added a comment. David's comment is still not done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 49610. mart added a comment. - remove dead symbol REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=49425&id=49610 BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17691 AFFECTED FI

D17691: Add rows info to the plasma virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > plasmavirtualdesktop_interface.h:55 > + * Sets how many rows the virtual desktops should be laid into > + * @since 5.53 > + */ Wrong version. > davidedmundson wrote in plasmavirtualdesktop_interface.h:51 > Is this even implemented?? I ca

D17691: Add rows info to the plasma virtual desktop protocol

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in plasma-virtual-desktop.xml:56 > This needs to be in a version 2 and done at the end with appropriate bumps > everywhere. This isn't done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 49425. mart added a comment. - verify the signal has been emitted REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=47854&id=49425 BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17

D17691: Add rows info to the plasma virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > mart wrote in test_plasma_virtual_desktop.cpp:280 > why? we want to compare the number of rows, no? What if rowsChanged is never emitted? In KWin, we usually do QVERIFY(spy.wait()); REPOSITORY R127 KWayland REVISION DETAIL https://phabricato

D17691: Add rows info to the plasma virtual desktop protocol

mart added inline comments. INLINE COMMENTS > zzag wrote in test_plasma_virtual_desktop.cpp:280 > QVERIFY why? we want to compare the number of rows, no? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: zzag, davidedmundson, hein, kd

D17691: Add rows info to the plasma virtual desktop protocol

hein added a task: T4457: [kwayland] Virtual Desktop protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

zzag added inline comments. INLINE COMMENTS > test_plasma_virtual_desktop.cpp:280 > +m_plasmaVirtualDesktopManagementInterface->setRows(3); > +rowsChangedSpy.wait(); > +QCOMPARE(m_plasmaVirtualDesktopManagement->rows(), 3); QVERIFY > plasmavirtualdesktop.h:168 > > +void rowsCh

D17691: Add rows info to the plasma virtual desktop protocol

hein added a comment. > The desktop cube shows everything flat, desktop grid is configurable (and hardcoded). The desktop grid effect uses the rows setting from the KCM for me. I don't think it's easy for users to understand that the KCM is configuring KWin only, instead of all of P

D17691: Add rows info to the plasma virtual desktop protocol

davidedmundson added a comment. I thought we had a whole conversation in the first set of reviews that views (layout) was independent of data. The desktop cube shows everything flat, desktop grid is configurable (and hardcoded). The pager is just another view, there's no need to sync w

D17691: Add rows info to the plasma virtual desktop protocol

hein added a comment. As per this , progress on this is currently blocking wrapping up Wayland virtual desktops support for 5.15. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: hein, kde-

D17691: Add rows info to the plasma virtual desktop protocol

mart created this revision. mart added reviewers: Plasma, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY in order for the pager to work correctly and not having to use a weird mix of wayland and