D17681: RFC: Cache translated strings in Job::emit functions

2018-12-19 Thread Kai Uwe Broulik
broulik added a comment. > That 6% goes to 0% i guess? Pretty much, goes down to 0.07% REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17681 To: broulik, davidedmundson, dfaure, chinmoyr Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D17681: RFC: Cache translated strings in Job::emit functions

2018-12-19 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:a48a277a8296: Cache translated strings in Job::emit functions (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17681?vs=47828&id=47874 REVISION DE

D17681: RFC: Cache translated strings in Job::emit functions

2018-12-19 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Good idea. This is indeed threadsafe, since in C++11 static objects are threadsafe. And this is done on demand the first time the function is called, so qApp exists and the catalogs a

D17681: RFC: Cache translated strings in Job::emit functions

2018-12-19 Thread Albert Astals Cid
aacid added a comment. That 6% goes to 0% i guess? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17681 To: broulik, davidedmundson, dfaure, chinmoyr Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D17681: RFC: Cache translated strings in Job::emit functions

2018-12-19 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17681 To: broulik, davidedmundson, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17681: RFC: Cache translated strings in Job::emit functions

2018-12-19 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: davidedmundson, dfaure, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY These are called repeatedly for every single file processed a