D17620: Make setHelp() public

2018-12-16 Thread Luigi Toscano
ltoscano added a comment. There may be another way: add a new public method which wraps the protected one, and when moving to KF6 a) make setHelp public and b) deprecate the new wrapper. I think - suggestions needed REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.

D17620: Make setHelp() public

2018-12-16 Thread Yuri Chornoivan
yurchor added a comment. In D17620#378112 , @aacid wrote: > In D17620#378110 , @yurchor wrote: > > > Abandoned due to the policy violation. Despite of the handful help pages invocation, it is obviou

D17620: Make setHelp() public

2018-12-16 Thread Albert Astals Cid
aacid added a comment. In D17620#378110 , @yurchor wrote: > Abandoned due to the policy violation. Despite of the handful help pages invocation, it is obvious that this change will never happen. > > Just a side note: the protected method is u

D17620: Make setHelp() public

2018-12-16 Thread Yuri Chornoivan
yurchor abandoned this revision. yurchor added a comment. Abandoned due to the policy violation. Despite of the handful help pages invocation, it is obvious that this change will never happen. Just a side note: the protected method is useless and can be removed without loss of any functi

D17620: Make setHelp() public

2018-12-16 Thread Albert Astals Cid
aacid added a comment. You can always just use QMetaObject::invokeMethod it's a bit lame, but slots are never really non-public if you use the metaobject system INLINE COMMENTS > elvisangelaccio wrote in kconfigdialog.h:176 > If I'm not mistaken, moving a function from `protected` to `public

D17620: Make setHelp() public

2018-12-16 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > kconfigdialog.h:176 > > +public Q_SLOTS: > +/** If I'm not mistaken, moving a function from `protected` to `public` breaks the ABI REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D17620 To: yurchor,

D17620: Make setHelp() public

2018-12-16 Thread Yuri Chornoivan
yurchor created this revision. yurchor added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. yurchor requested review of this revision. REVISION SUMMARY Sometimes it is useful to connect configuration dialogs directly with the corresp