dfaure added a comment.
What happened to the unittest promised by the commit log? ;)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17619
To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcoredirlister.cpp:1580
> +while (!dir->lstItems.isEmpty()) {
> +const KFileItem oldItem = dir->lstItems.takeFirst();
> +
jtamate updated this revision to Diff 47666.
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.
I think this time I got the problem right.
One of the classics: I was modifying the list while it was being used.
REPOSITORY
R2
elvisangelaccio added inline comments.
INLINE COMMENTS
> kdirlistertest.cpp:1299-1308
> +const QString dirX = m_tempDir.path() + "/x";
> +QVERIFY(QDir().mkdir(dirX));
> +const QString dirX1 = m_tempDir.path() + "/x/x1";
> +QVERIFY(QDir().mkdir(dirX1));
> +const QString dirX2 =
elvisangelaccio added a comment.
Unfortunately it's still crashing for me, even with this patch.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17619
To: jtamate, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
jtamate edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17619
To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.
REVISION SUMMARY
Add a unit test that fails before applying the patch and doesn't after the
