D17299: move implementation of document get to cpp file

2018-12-02 Thread Alexander Stippich
astippich abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17299: move implementation of document get to cpp file

2018-12-02 Thread Stefan Brüns
bruns added a comment. yes, please. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17299: move implementation of document get to cpp file

2018-12-02 Thread Alexander Stippich
astippich added a comment. Really just a cosmetic change for consistency, if you don't want it in, I'm fine with dropping it REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich

D17299: move implementation of document get to cpp file

2018-12-02 Thread Stefan Brüns
bruns added a comment. Why? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17299: move implementation of document get to cpp file

2018-12-02 Thread Alexander Stippich
astippich added a dependent revision: D17300: add result to baloo namespace. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17299: move implementation of document get to cpp file

2018-12-02 Thread Alexander Stippich
astippich added a dependency: D17298: remove unused doc_id from result. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17299 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17299: move implementation of document get to cpp file

2018-12-02 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY for consistency REPOSITORY R293 Baloo BRANCH result_doc REVISI