D17281: Add icon to KBuildSycocaProgressDialog cancel button

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3b320f7a32f3: Add icon to KBuildSycocaProgressDialog cancel button (authored by GB_2, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17281?vs=466

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 added a comment. Ok. Email: febe...@gmail.com REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio Cc: bcooksley, elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michae

D17281: Add icon to KBuildSycocaProgressDialog cancel button

bcooksley added a comment. Phabricator has a strong privacy model, meaning your email address is not accessible to anyone except you, so you'll need to post it here in this review so it can be committed to our repositories. Sorry for any confusion around this. REPOSITORY R241 KIO REVISI

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 added a comment. In D17281#370253 , @ngraham wrote: > @GB_2, can you provide an email address so we can land this for you? Thanks! How can I provide an email address in the Phabriactor webinterface? I already provided an email in my

D17281: Add icon to KBuildSycocaProgressDialog cancel button

ngraham added a comment. @GB_2, can you provide an email address so we can land this for you? Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde,

D17281: Add icon to KBuildSycocaProgressDialog cancel button

elvisangelaccio accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, b

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 updated this revision to Diff 46677. GB_2 added a comment. Improve code (pass `this` as parent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17281?vs=46637&id=46677 REVISION DETAIL https://phabricator.kde.org/D17281 AFFECTED FILES src/widgets/kbui

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, a

D17281: Add icon to KBuildSycocaProgressDialog cancel button

elvisangelaccio added inline comments. INLINE COMMENTS > kbuildsycocaprogressdialog.cpp:71 > setAutoClose(false); > +QDialogButtonBox* dialogButtonBox = new > QDialogButtonBox(QDialogButtonBox::Cancel); > +setCancelButton(dialogButtonBox->button(QDialogButtonBox::Cancel)); Please a

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, a

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 updated this revision to Diff 46637. GB_2 edited the test plan for this revision. GB_2 added a comment. Improved code. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17281?vs=46615&id=46637 REVISION DETAIL https://phabricator.kde.org/D17281 AFFECTED FI

D17281: Add icon to KBuildSycocaProgressDialog cancel button

elvisangelaccio added inline comments. INLINE COMMENTS > kbuildsycocaprogressdialog.cpp:71-73 > +QDialogButtonBox dialogButtonBox; > +dialogButtonBox.setStandardButtons(QDialogButtonBox::Cancel); > +setCancelButton(dialogButtonBox.button(QDialogButtonBox::Cancel)); I'm surprised this

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 added a comment. Ok, thanks for the info :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, aaro

D17281: Add icon to KBuildSycocaProgressDialog cancel button

ngraham accepted this revision. ngraham added reviewers: Frameworks, cfeck. ngraham added a comment. This revision is now accepted and ready to land. Works and seems reasonable enough. Anyone else have any opinions on the matter? Also @gb_2, please provide your real name and email address

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 created this revision. GB_2 added a project: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY The cancel button in the KBuildSycocaProgressDialog (showing that the system configuration is upda