D17251: Update Ip-tunnel settings

2018-11-30 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R282:d2531a32e28d: Update Ip-tunnel settings (authored by pranavgade, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17251?vs=46535&id=46540#toc REPOSITORY R282 NetworkMan

D17251: Update Ip-tunnel settings

2018-11-30 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > iptunnelsetting.h:28 > +#if !NM_CHECK_VERSION(1, 12, 0) > +#define NM_SETTING_IP_TUNNEL_FLAGS"flags" > + No need to define this here, it's a

D17251: Update Ip-tunnel settings

2018-11-30 Thread Pranav Gade
pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Fixed a few things in ip-tunnel settings REPOSITORY R282 NetworkManagerQ