This revision was automatically updated to reflect the committed changes.
Closed by commit R39:8b4cd5f37947: KateViewInternal: Remove unneeded functions
(authored by loh.tar, committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17193?vs=46
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
I am happy with this ;=)
Thanks for adding documentation to the header, such stuff is very welcome!
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17193
loh.tar updated this revision to Diff 46473.
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a comment.
- Prefer function calls for member excess
- Merge KateViewInternal::updateView with KateViewInternal::doUpdateView
- Add documen
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I would prefer function calls to members, in the most cases, the performance
difference is not measurable, even without inline.
For non-exported functions that are one lin
loh.tar updated this revision to Diff 46411.
loh.tar added a comment.
I think that's all.
Well, it looks less beneficial as previous anticipated by me, but I think
it's still the right direction.
Just a view questions regarding the mix in the KTextEditor::ViewPrivate code
how to acces
cullmann added a comment.
Simplifications in that way are ok in my eye, given the extra level of
functions have no gain. (not even encapsulation)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17193
To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frame
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.
TEST PLAN
This is only an example snippet to show that obviously something could
