D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

probono added a comment. Thank you @kossebau, really nice to see this. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: probono, TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

TheAssassin added a comment. Yep, it's really nice, thanks @kossebau! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

ngraham added a comment. Thanks for the nice new icon! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

This revision was automatically updated to reflect the committed changes. Closed by commit R266:e3266db59d2f: Add icons for application-vnd.appimage/x-iso9660-appimage (authored by kossebau). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17086?vs=46231&i

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

kossebau added a comment. Thanks for feedback/review :) REPOSITORY R266 Breeze Icons BRANCH addappimageiconv2 REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

TheAssassin accepted this revision. REPOSITORY R266 Breeze Icons BRANCH addappimageiconv2 REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, that was it. Looks beautiful. Ship it! REPOSITORY R266 Breeze Icons BRANCH addappimageiconv2 REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham Cc

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

kossebau added a comment. In D17086#366120 , @ngraham wrote: > Looks great to me then! > > But how do I make this work? I compiled and installed the icon and verified that it's installed in the right place. But my AppImage isn't getting the n

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

ngraham added a comment. Looks great to me then! But how do I make this work? I compiled and installed the icon and verified that it's installed in the right place. But my AppImage isn't getting the new icon, not even after running `update-desktop-database`. F6441744: Weird.png

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

kossebau added a comment. In D17086#366111 , @ngraham wrote: > Thanks, that looks great! As for the background color, I'd say it's okay to use a different shade of blue if it would better match the AppImage branding. For now I favor breez

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

kossebau retitled this revision from "Add icons for application-vnd.appimage" to "Add icons for application-vnd.appimage/x-iso9660-appimage". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham Cc: TheAssassin, ngraham, kde-frameworks-

D17086: Add icons for application-vnd.appimage

kossebau updated this revision to Diff 46231. kossebau added a comment. - add symlinks for application-x-iso9660-appimage to application-vnd.appimage REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17086?vs=46229&id=46231 BRANCH addappimageiconv2 RE

D17086: Add icons for application-vnd.appimage

ngraham added a comment. Thanks, that looks great! As for the background color, I'd say it's okay to use a different shade of blue if it would better match the AppImage branding. Don't worry about participating in the style change discussion; if that ever bears any fruit, we'll change th

D17086: Add icons for application-vnd.appimage

TheAssassin added a comment. Quoting myself: > You might also add a 1 somewhere in there to indicate the type, but as both are still relevant and should mostly work equally, that's not really necessary. I think more and more that there shouldn't be different icons. The user shouldn'

D17086: Add icons for application-vnd.appimage

kossebau added a comment. F6441665: Screenshot_20181126_014024.png for an updated example usage. @ngraham How do you create those summary pictures you used above for the comparison previews? In D17086#366097

D17086: Add icons for application-vnd.appimage

TheAssassin added a comment. AFAIK `vnd.appimage` resolves to type 2, whereas `x-[iso9660-]appimage` resolves to type 1. At least that's the MIME data I've been working with all the time so far. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kosseba

D17086: Add icons for application-vnd.appimage

kossebau added a comment. In D17086#363977 , @ngraham wrote: > We have two options here: > > 1. Follow the style and make the AppImage icon look like a document with a folded-over corner that has an the AppImage logo in the middle > 2. Eng

D17086: Add icons for application-vnd.appimage

TheAssassin added a comment. The new logos look great! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage

kossebau updated this revision to Diff 46229. kossebau added a comment. - use document-style icon shape, to match other existing icons for executables - use Breeze palette color that is more close to AppImage logo one REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabri

D17086: Add icons for application-vnd.appimage

TheAssassin added a comment. AppImages are, after all, only ELF executables. They're not archives. Using a zipper implies this, though. I really like the initial version that mimics the "normal executable" icon better. The dark blue is quite nice, but I thought perhaps a color from the offic

D17086: Add icons for application-vnd.appimage

ngraham added a comment. That reasoning makes sense. Currently AppImages get the generic `application-x-executable` which isn't great: F6436057: Screenshot_20181121_193014.png The document motif isn't really accurate here, but it's also used by

D17086: Add icons for application-vnd.appimage

kossebau added a comment. In D17086#363855 , @ngraham wrote: > Thanks for the icon! I'd recommend mimicking the style of the other package icons that have a symbol: > > In other words, add a zipper towards the right-side,, put the AppImage s

D17086: Add icons for application-vnd.appimage

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks for the icon! I'd recommend mimicking the style of the other package icons that have a symbol: F6435828: Screenshot_20181121_151526.png

D17086: Add icons for application-vnd.appimage

kossebau added a comment. Open questions: - how to support the dark icon set? - what would be better colors? Example of icon use with 64 & 16 pixel size, and bigger in preview: F6435751: Screenshot_20181121_220325.png The icon also fixe

D17086: Add icons for application-vnd.appimage

kossebau created this revision. kossebau added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Done based on the shape of the official AppImage logo, basing on SVG code of the ori