D17078: Make it possible to use KAboutData/License/Person from QML

apol closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure, aacid Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

apol marked 2 inline comments as done. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure, aacid Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

aacid accepted this revision. aacid added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kaboutdata.h:92 > + * > + * Default arguments @since 5.53 > */ Change "Default arguments @since 5.53" to "name default argument @since 5.53" REPOSITORY R

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 46274. apol added a comment. @since REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=46273&id=46274 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 AFFECTED FILES src/lib/kaboutdata.cpp

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 46273. apol added a comment. More @since REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=46272&id=46273 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 AFFECTED FILES src/lib/kaboutdat

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 46272. apol added a comment. Polishing REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=46271&id=46272 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 AFFECTED FILES src/lib/kaboutdata.

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 46271. apol added a subscriber: aacid. apol added a comment. Add CONSTANT as suggested by @aacid REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=45984&id=46271 BRANCH master REVISION DETAIL https://phabri

D17078: Make it possible to use KAboutData/License/Person from QML

apol added a comment. Can somebody accept it or reject it, please? :P REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

mart added a comment. adding a default value should be bc, the opposite of course is not.. in its current state, looks good to me REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: mart, mpyne, broulik, anthonyfieroni, kde-f

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 45984. apol added a comment. Make new constructors explicit REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=45964&id=45984 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 AFFECTED FILES

D17078: Make it possible to use KAboutData/License/Person from QML

mpyne added a comment. In D17078#363886 , @apol wrote: > In D17078#363772 , @anthonyfieroni wrote: > > > You can't change parameters in methods or constructors, it's a BIC. > > > https://commun

D17078: Make it possible to use KAboutData/License/Person from QML

apol added a comment. In D17078#363772 , @anthonyfieroni wrote: > You can't change parameters in methods or constructors, it's a BIC. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B REPOSITORY R244 KCoreAddo

D17078: Make it possible to use KAboutData/License/Person from QML

broulik added a comment. You can change default values just fine, it requires re-compilation to use them but no ABI implications. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-deve

D17078: Make it possible to use KAboutData/License/Person from QML

anthonyfieroni added a reviewer: dfaure. anthonyfieroni added a comment. You can't change parameters in methods or constructors, it's a BIC. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: anthonyfieroni, kde-frameworks-dev

D17078: Make it possible to use KAboutData/License/Person from QML

apol added a dependent revision: D17079: Provide a qqc2/kirigami-based about page. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Exposes their properties through Q_GADGET. Makes it possible to export them as QVariant b