D17071: Don't include any directory sizes in DirectorySizeJob

sasch added a comment. You created the patch within hours, it was approved within days. One year later we still have nothing within master or any usable distro. Any plans at all to show correct file sizes with KDE? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D170

D17071: Don't include any directory sizes in DirectorySizeJob

sasch added a comment. @davidedmundson any reference or version when you plan to make this "live"? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: bruns, sasch, adridg, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D17071: Don't include any directory sizes in DirectorySizeJob

dfaure added a comment. Well, this patch can still go in then, it makes one of the two values correct :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: bruns, sasch, adridg, apol, kde-frameworks-devel, michaelh, ngraham

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson abandoned this revision. davidedmundson added a comment. I put it up as an RFC, as I spent too long debugging why I had a difference. I don't like that we're in this uncanny valley of neither disk space nor sum of file size, but maybe I should do it properly and show two valu

D17071: Don't include any directory sizes in DirectorySizeJob

bruns added a comment. In D17071#461613 , @dfaure wrote: > I don't object to the patch, but maybe the properties dialog (and other users of this job) should indicate that the number being shown is "sum of file sizes, not actual disk space usage,

D17071: Don't include any directory sizes in DirectorySizeJob

dfaure added a comment. I don't object to the patch, but maybe the properties dialog (and other users of this job) should indicate that the number being shown is "sum of file sizes, not actual disk space usage, which is larger" (blocks, inodes, directory sizes...) REPOSITORY R241 KIO BRA

D17071: Don't include any directory sizes in DirectorySizeJob

sasch added a comment. What's blocking here to merge this in Master? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: sasch, adridg, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

adridg added a comment. With UFS, stat(1) tells me [adridg@beastie .../kio/build]$ stat . 2080587972 222556 drwxr-xr-x 9 adridg adridg 4294967295 17 "Nov 22 14:40:28 2018" "Nov 22 14:42:22 2018" "Nov 22 14:42:22 2018" "Nov 22 14:39:51 2018" 131072 17 0x800 . So that's a size o

D17071: Don't include any directory sizes in DirectorySizeJob

dfaure added a comment. (sure it's convenient for the unittest, but less meaningful for the users) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

dfaure added a comment. Hmm hmm. The goal of this was to behave like "du" as much as possible. As you say, the real bug isn't that we count directories, but that we count files "as is" instead of blocks. But I'm not sure how easily we could get block information from here. REPOSITORY R241

D17071: Don't include any directory sizes in DirectorySizeJob

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson updated this revision to Diff 45947. davidedmundson edited the summary of this revision. davidedmundson edited the test plan for this revision. davidedmundson added a comment. Squash REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17071?vs=45942&i

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson added a dependency: D17070: Don't double-count size of directories in DirectorySizeJob. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Running stat on a directory gives a size of on ext3 gives a size of 4096. Running stat on a directory