D16919: Re-add DBus test

2018-11-26 Thread Ben Cooksley
bcooksley added a comment. The best we have documentation wise is https://phabricator.kde.org/w/continuous-integration/ however these are quite out of date (and incomplete). REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #framew

D16919: Re-add DBus test

2018-11-25 Thread Kurt Hindenburg
hindenburg added a comment. Yes, I was actually surprised I managed to get it all to run. Are there official docs on how to setup an ci image and run applications? If not, it would be helpful. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmunds

D16919: Re-add DBus test

2018-11-25 Thread Ben Cooksley
bcooksley added a comment. Okay, that is odd. I'll try reproducing the issue on the CI nodes in the next day or so - you changed 'kcalcore' in that example to 'konsole' I assume? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole

D16919: Re-add DBus test

2018-11-23 Thread Kurt Hindenburg
hindenburg added a comment. In D16919#364934 , @bcooksley wrote: > Yes, that is basically what the CI does so should be a pretty good method of reproducing it's results. > Did you run "make tests" / "ctest" or did you use the run-tests.py scr

D16919: Re-add DBus test

2018-11-23 Thread Ben Cooksley
bcooksley added a comment. Yes, that is basically what the CI does so should be a pretty good method of reproducing it's results. Did you run "make tests" / "ctest" or did you use the run-tests.py script to execute the unit tests? REPOSITORY R319 Konsole REVISION DETAIL https://phabri

D16919: Re-add DBus test

2018-11-23 Thread Kurt Hindenburg
hindenburg added a comment. In D16919#364587 , @bcooksley wrote: > When you did your reproduction attempt @hindenburg did you use the binaries the CI system itself uses, or did you build Frameworks, etc yourself? I used the script in the

D16919: Re-add DBus test

2018-11-22 Thread Ben Cooksley
bcooksley added a comment. When you did your reproduction attempt @hindenburg did you use the binaries the CI system itself uses, or did you build Frameworks, etc yourself? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #framewor

D16919: Re-add DBus test

2018-11-22 Thread Kurt Hindenburg
hindenburg added a comment. I manage to build the docker kdeorg/ci-suse-qt59 image - and of course the tests pass - so I'm not sure how to help now. I've already disabled this test again to avoid the sysadmins having more work to do. REPOSITORY R319 Konsole REVISION DETAIL https://pha

D16919: Re-add DBus test

2018-11-16 Thread Kurt Hindenburg
hindenburg added a comment. yea - feel free to commit any changes related to this yourself if you want. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #frameworks, hindenburg Cc: hindenburg, konsole-devel, ngraham, maximilianocuri

D16919: Re-add DBus test

2018-11-16 Thread David Edmundson
davidedmundson added a comment. CI seems to be frozen again. :( REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #frameworks, hindenburg Cc: hindenburg, konsole-devel, ngraham, maximilianocuria

D16919: Re-add DBus test

2018-11-16 Thread Kurt Hindenburg
This revision was automatically updated to reflect the committed changes. Closed by commit R319:3eb9a34f62c8: Re-add DBus test (authored by davidedmundson, committed by hindenburg). REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16919?vs=45568&id=45591 REVISI

D16919: Re-add DBus test

2018-11-16 Thread Kurt Hindenburg
hindenburg accepted this revision. hindenburg added a comment. This revision is now accepted and ready to land. Thanks so much for looking into this. REPOSITORY R319 Konsole BRANCH master REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #frameworks, hin

D16919: Re-add DBus test

2018-11-16 Thread David Edmundson
davidedmundson created this revision. davidedmundson added reviewers: Konsole, Frameworks. Herald added a project: Konsole. Herald added a subscriber: konsole-devel. davidedmundson requested review of this revision. REVISION SUMMARY Ported from KProcess::startDetached to a QProcess we can kill s