D16905: Add a generic sorting options icon

trickyricky26 updated this revision to Diff 45599. trickyricky26 edited the test plan for this revision. trickyricky26 added a comment. This revision is now accepted and ready to land. - Add new generic sorting icons, rename existing ordered sorting icons to -name scheme (see updated revi

D16905: Add a generic sorting options icon

ngraham added a comment. All right, let's go with that. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add a generic sorting options icon

trickyricky26 added a comment. | size | `view-sort` | `view-sort-ascending` | `view-sort-descending` | | - | --- | - | -- | | `16px`| F6427148: view-sort-16.svg.png

D16905: Add a generic sorting options icon

ngraham added a comment. I prefer that version, thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add a generic sorting options icon

trickyricky26 added a comment. This is how the set looks with the arrows above the lines in the descending versions: | size | `view-sort` | `view-sort-ascending` | `view-sort-descending` | | - | --- | - | --

D16905: Add a generic sorting options icon

ngraham added a comment. For the `-descending` versions, could we consider moving the arrows up so they don't obscure some of the horizontal lines? The effect is okay for the larger versions, but I think it doesn't work for the 16px version because the descending nature of the lines is lost.

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360449 , @trickyricky26 wrote: > I wasn't quite sure if I should use 2px strokes in the `32px` versions, so I used 1px for now as that is more consistent with the rest. > If there are no more suggestions, I w

D16905: Add a generic sorting options icon

trickyricky26 added a comment. I made all necessary versions of these icons (`24px` not shown since they're the same as `22px`): | size | `view-sort` | `view-sort-ascending` | `view-sort-descending` | | -- | --- | - | -- | | `16px`

D16905: Add a generic sorting options icon

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add a generic sorting options icon

ngraham added a comment. +1 to everything @ndavis is saying. I love the new double-arrow versions! Those are just what I had in mind. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-fram

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360075 , @trickyricky26 wrote: > So should I include the renaming of the existing icons and adding of the ascending and descending versions of these new ones in this revision? That way applications that use `vi

D16905: Add a generic sorting options icon

trickyricky26 added a comment. So should I include the renaming of the existing icons and add ascending and descending versions of these new ones in this revision? That way applications that use `view-sort-ascending` for alphabetical order will have it replaced, but I guess that's okay becau

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360055 , @trickyricky26 wrote: > I have adjusted the arrows to fit the `view-sort-ascending` style: > > F6425856: sorting-icon-22-alt.png 22px > F6425879: sorting-ic

D16905: Add a generic sorting options icon

trickyricky26 planned changes to this revision. trickyricky26 added a comment. I have adjusted the arrows to fit the `view-sort-ascending` style: F6425856: sorting-icon-22-alt.png 22px F6425879: sorting-icon-16-alt.png

D16905: Add a generic sorting options icon

ngraham added a comment. In D16905#360028 , @ndavis wrote: > You mean sort of like the arrow on `view-sort-ascending` but going both ways? F6425832: Screenshot_20181115_143752.png Exactly! REPOSITO

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360021 , @ngraham wrote: > I was imagining vertical lines, not horizontal. A bit more like this (WARNING: exceptionally crude mockup approaching) > > F6425824: sorting-icon-22.png

D16905: Add a generic sorting options icon

ngraham added a comment. I was imagining vertical lines, not horizontal. A bit more like this (WARNING: exceptionally crude mockup approaching) F6425824: sorting-icon-22.png REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched fr

D16905: Add a generic sorting options icon

ndavis added a comment. I think your original design looked the best. I don't think having lines extend to the area between the arrows makes the meaning significantly clearer. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phab

D16905: Add a generic sorting options icon

trickyricky26 added a comment. I do agree that the 22px version is clearer with two lines in between the arrows: F6425790: sorting-icon-22-alt.png To fit this into the 16px was difficult, however: F6425793: sorting-icon-16-alt.png

D16905: Add a generic sorting options icon

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add a generic sorting options icon

ngraham added a comment. Generally that was what I was looking for, thanks! I wonder how it would look with a vertical line or two between the arrows, though. Might make the concept a bit clearer? REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION

D16905: Add a generic sorting options icon

ndavis added subscribers: ngraham, ndavis. ndavis accepted this revision as: ndavis. ndavis added a comment. This revision is now accepted and ready to land. It looks good to me, but since @ngraham reported bug #393318, I'd like his opinion as well. Also, put this at the bottom of your summary

D16905: Add a generic sorting options icon

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added reviewers: VDG, Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze Cc: kde-frameworks-devel, mich

D16905: Add a generic sorting options icon

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kd