D16878: Resolve symlinks in exclude folders

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=342224? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16878 To: poboiko, #frameworks, #baloo Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D16878: Resolve symlinks in exclude folders

poboiko added a comment. I believe can do something better here. I think if we stick to canonical paths everywhere, and resolve symlinks ASAP (but still follow them), that might solve all the problems. In D16878#359864 , @bruns wrote: > B

D16878: Resolve symlinks in exclude folders

bruns added a comment. Because it can never be consistent. What happens when I create two symlinks to the same folder, and put one link into includeFolders, the other one in excludeFolders? What really should happen, the indexer should **never** follow symlinks, but only add files by t

D16878: Resolve symlinks in exclude folders

poboiko added a comment. In D16878#359442 , @bruns wrote: > IMHO we should just disallow specifying symlinks in both include/excludeFolders. The user can just use exludeFolders = /storage/stuff if he wants to exclude it. Why not? This ki

D16878: Resolve symlinks in exclude folders

bruns added a comment. IMHO we should just disallow specifying symlinks in both include/excludeFolders. The user can just use exludeFolders = /storage/stuff if he wants to exclude it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16878 To: poboiko, #frameworks, #ba

D16878: Resolve symlinks in exclude folders

poboiko created this revision. poboiko added reviewers: Frameworks, Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Assume user has `~/stuff` folder, that is symlinked to i.e. `/storage/