D16665: Add programmaticaly useful error signalling

leinir added a dependent revision: D16776: Better error handling in KNewStuff backend. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16665 To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D16665: Add programmaticaly useful error signalling

leinir added a comment. In D16665#355578 , @apol wrote: > Maybe it would be good to produce the Discover patch before committing this to make sure the API is the one we want. Good idea, yes, i'll get that whipped together and submitted wi

D16665: Add programmaticaly useful error signalling

apol added a comment. Maybe it would be good to produce the Discover patch before committing this to make sure the API is the one we want. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16665 To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff, mich

D16665: Add programmaticaly useful error signalling

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D16665 To: leinir, #knewstuff, apol Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D16665: Add programmaticaly useful error signalling

leinir updated this revision to Diff 45032. leinir marked an inline comment as done. leinir added a comment. Adjust the patch to address @apol's comment about deprecating the old error signal REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16665?vs=44855&

D16665: Add programmaticaly useful error signalling

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in engine.h:430 > I would include the error message here and deprecate `signalError`. Otherwise > it's going to be a mess matching both signals. Quite a good point, yes - i've done a bit of jiggl

D16665: Add programmaticaly useful error signalling

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > engine.h:430 > + */ > +void signalErrorCode(const KNSCore::ErrorCode &errorCode, const QVariant > &metadata); > I would include the error message here

D16665: Add programmaticaly useful error signalling

leinir created this revision. leinir added reviewers: KNewStuff, apol. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Previously, KNSCore only signalled errors usin