D16643: Correct m_enabled on DragMove

2018-11-03 Thread trmdi
trmdi added a comment. In D16643#353517 , @ngraham wrote: > Wow, does this really fix 396011!? If so, congratulations! I wish I could test, but alas (or thankfully?) I don't experience the problem. Yes, it fixes the problem on my system.

D16643: Correct m_enabled on DragMove

2018-11-03 Thread David Korth
dkorth added a comment. This fixes the issue for me for both desktop icons and panel widgets. Using KF 5.51, Plasma 5.14.2, and Qt 5.11.2. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: dkor

D16643: Correct m_enabled on DragMove

2018-11-03 Thread Nathaniel Graham
ngraham added reviewers: broulik, Plasma, hein, davidedmundson. ngraham added a comment. Wow, does this really fix 396011!? If so, congratulations! I wish I could test, but alas (or thankfully?) I don't experience the problem. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabrica

D16643: Correct m_enabled on DragMove

2018-11-03 Thread trmdi
trmdi created this revision. trmdi added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trmdi requested review of this revision. REVISION SUMMARY - `m_enabled` could change while moving. - Don't call `setAccepted(false)` wrongly if `event