D16633: Add root version of drive-harddisk

acrouthamel added a comment. > I did not add drive-harddisk-home in this commit because it was simply too difficult to make an easily readable symbol for home on the 16px version. What about ~ or $ ? Tilde would probably be the best, and you could exaggerate t

D16633: Add root version of drive-harddisk

This revision was automatically updated to reflect the committed changes. Closed by commit R266:67312861ffa3: Add root version of drive-harddisk (authored by ndavis, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16633?vs=44797&id=4

D16633: Add root version of drive-harddisk

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH drive-harddisk-root_and_home (branched from master) REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh

D16633: Add root version of drive-harddisk

ngraham added a comment. Awesome, let's do it. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16633: Add root version of drive-harddisk

ngraham added a dependent revision: D16653: Use the new `drive-harddisk-root` icon for the root volume. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16633: Add root version of drive-harddisk

ndavis updated this revision to Diff 44797. ndavis added a comment. Change color of forward slash to grey REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16633?vs=44759&id=44797 BRANCH drive-harddisk-root_and_home (branched from master) REVISION DET

D16633: Add root version of drive-harddisk

ngraham added a comment. That's true. Okay, let's stay with a slash for now and just make it Icon Gray. In general I'd like to see us reduce our use of the red color for things that aren't actually destructive or errors, which I think will make it more meaningful for things that are. REPOSI

D16633: Add root version of drive-harddisk

ndavis added a comment. In D16633#353510 , @ngraham wrote: > Hmm, you're right. > > Maybe we could use a slash for the 16px version, and the plasma logo for the larger ones? That would cause confusion though. The meaning of a forward

D16633: Add root version of drive-harddisk

ngraham added a comment. Hmm, you're right. Maybe we could use a slash for the 16px version, and the plasma logo for the larger ones? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16633: Add root version of drive-harddisk

ndavis added a comment. In D16633#353308 , @ngraham wrote: > Thank you! Two comments: > > - I'm not sure using the negative color is appropriate here. That color is used for dangerous operations or error conditions, neither of which apply to

D16633: Add root version of drive-harddisk

ngraham added a comment. Thank you! Two comments: - I'm not sure using the negative color is appropriate here. That color is used for dangerous operations or error conditions, neither of which apply to the OS volume. It's true that you could potentially blow yourself up by messing with

D16633: Add root version of drive-harddisk

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16633: Add root version of drive-harddisk

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16633: Add root version of drive-harddisk

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG: 399307 I did not add `drive-harddisk-home` in this commit because it was simply too