This revision was automatically updated to reflect the committed changes.
Closed by commit R286:0a26d39b27cb: use qlatin1 for embedded image extractor
(authored by astippich).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16583?vs=44718&id=44826
REVISI
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
embedded_image_latin1
REVISION DETAIL
https://phabricator.kde.org/D16583
To: astippich, mgallien, bruns, apol
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astip
astippich edited the summary of this revision.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16583
To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
astippich updated this revision to Diff 44718.
astippich added a comment.
- coding style
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16583?vs=44619&id=44718
BRANCH
embedded_image_latin1
REVISION DETAIL
https://phabricator.kde.org/D16583
AFFE
astippich marked an inline comment as done.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16583
To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
bruns added a comment.
Please use proper Capitalization in the Summary.
INLINE COMMENTS
> embeddedimagedata.cpp:175
> TagLib::List lstPic;
> -if (mimeType == QStringLiteral("audio/ogg") || mimeType ==
> QStringLiteral("audio/x-vorbis+ogg")) {
> +if (mimeType == QLati
astippich created this revision.
astippich added reviewers: mgallien, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
use qlatin1string where applicable instead
of qstringliter
