D16563: Remove unused variables

2018-11-01 Thread Albert Astals Cid
aacid updated this revision to Diff 44617. aacid added a comment. actually use the variables REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16563?vs=44586&id=44617 BRANCH arcpatch-D16563 REVISION DETAIL https://phabricator.kde.org/D16563 AFFECTED FILES

D16563: Remove unused variables

2018-10-31 Thread Stefan BrĂ¼ns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > transaction.cpp:519 > out << "\tFileNameTermsDB: "; > for (const QByteArray& term : terms) { > out << term << " "; sh

D16563: Remove unused variables

2018-10-31 Thread Nathaniel Graham
ngraham added reviewers: Baloo, bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16563 To: aacid, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16563: Remove unused variables

2018-10-31 Thread Albert Astals Cid
aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY As far as i can see the declaration of the variables and calling get "does nothing", so we can remove them with