D15983: React to config updates inside indexer

poboiko closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15983: React to config updates inside indexer

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH arcpatch-D15983 REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov,

D15983: React to config updates inside indexer

poboiko added a comment. In D15983#434247 , @ngraham wrote: > Can you rebase this on master again? Sorry for the radio silence. :( Nevermind, I also kinda forgot about this :) Seems like this patch still applies to current master:

D15983: React to config updates inside indexer

ngraham added a comment. Can you rebase this on master again? Sorry for the radio silence. :( REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh

D15983: React to config updates inside indexer

poboiko added a comment. Ping? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15983: React to config updates inside indexer

poboiko edited the summary of this revision. poboiko added reviewers: bruns, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh, astippich

D15983: React to config updates inside indexer

poboiko updated this revision to Diff 45452. poboiko added a comment. It's a bad idea to removeRecursively starting from root of the tree (documentid 0). If user has indexed `/home/username` folder, there is also an index entry for `/home` (that's how IdTreeDB works). However, `/home` sho

D15983: React to config updates inside indexer

poboiko updated this revision to Diff 45451. poboiko added a comment. Rebase on master REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15983?vs=43446&id=45451 BRANCH arcpatch-D15983 REVISION DETAIL https://phabricator.kde.org/D15983 AFFECTED FILES src

D15983: React to config updates inside indexer

poboiko marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15983: React to config updates inside indexer

poboiko updated this revision to Diff 43446. poboiko added a comment. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. Address raised issues REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15983?vs=42971&id=43446 BRAN

D15983: React to config updates inside indexer

bruns added a comment. Looks good in general, but have to think a little bit more about it .. INLINE COMMENTS > fileindexscheduler.cpp:125 > > +// This should be above content indexing, because there can be files > that should not be indexed in the DB > +// (i.e. if config was chan

D15983: React to config updates inside indexer

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. poboiko requested review of this revision. REVISION SUMMARY In case a config was changed, we need to: 1. Stop the ContentIndexer (bug 373430) 2. Remove all scheduled indexing of files that should not be indexed 3