This revision was automatically updated to reflect the committed changes.
Closed by commit R238:1caa28ea5614: Use specified Perl interpreter instead of
relying on PATH (authored by zrax, committed by ltoscano).
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.
Uhm, I guess than this can go in then.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D15927
To: zrax, ltoscano
Cc: ltoscano, vonreth, kde-doc-english, kde-f
vonreth added a comment.
ah sorry I took this for a config file, everything is fine then.
Note to myself: Don't review code on the phone
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D15927
To: zrax
Cc: vonreth, kde-doc-english, kde-frameworks-devel, mich
zrax added a comment.
PERL_EXECUTABLE is set by cmake's FindPerl module
(https://cmake.org/cmake/help/v3.0/module/FindPerl.html), so it should always
be defined. This only fixes the case where it's overridden on the command line
(or cmake-gui, etc).
REPOSITORY
R238 KDocTools
REVISION DE
vonreth added a comment.
Please fallback on looking up perl from path if that perl does not exists.
Purely relying on a hardcoded path would break the capability of relocating
kdoctools.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D15927
To: zrax
Cc: vonreth,
zrax created this revision.
Herald added projects: Frameworks, Documentation.
Herald added a subscriber: kde-doc-english.
zrax requested review of this revision.
REVISION SUMMARY
If a PERL_EXECUTABLE is passed on the CMake command line, e.g. because the
default one in PATH is insufficient, kdoc
