D15591: Add Open Document thumbnailer

abetts added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kossebau, jtamate, fvogt, wbauer Cc: abetts, kde-frameworks-devel, kfm-devel, leinir, kossebau, jtamate, ngraham, feverfew, michaelh, spoorun

D15591: Add Open Document thumbnailer

This revision was automatically updated to reflect the committed changes. Closed by commit R320:6828ff113ac3: Add Open Document thumbnailer (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15591?vs=41926&id=41934 REVISION DETAIL http

D15591: Add Open Document thumbnailer

broulik added a reviewer: wbauer. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kossebau, jtamate, fvogt, wbauer Cc:

D15591: Add Open Document thumbnailer

jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. Ok by side. It installs now, and don't ask for passwords. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kosse

D15591: Add Open Document thumbnailer

broulik updated this revision to Diff 41926. broulik added a reviewer: fvogt. broulik added a comment. - Add missing desktop file REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15591?vs=41905&id=41926 REVISION DETAIL https://phabricator.kde.org/D15591

D15591: Add Open Document thumbnailer

kossebau added a comment. Just FYI, as I was added, I currently have no time reserved for document related code work: There is such a thumbnailer for OpenDocument Format document which exposes the preview/thumbnail picture from the data since ages on what now is store.kde.org, here my o

D15591: Add Open Document thumbnailer

broulik planned changes to this revision. broulik added a comment. > ...that doesn't seem likely, that'd be like Plasma using Kicker classes from KDE3 times, which is the last time Calligra was called that ;) I wanted to say `Ko` classes as that's what they're prefixed with but I didn't

D15591: Add Open Document thumbnailer

leinir added a comment. In D15591#328150 , @broulik wrote: > [...]actually uses KOffice classes ...that doesn't seem likely, that'd be like Plasma using Kicker classes from KDE3 times, which is the last time Calligra was called th

D15591: Add Open Document thumbnailer

jtamate requested changes to this revision. jtamate added a comment. This revision now requires changes to proceed. I'm trying to check if it works with password-protected files, but I can't install it. The patch is missing opendocumentthumbnail.desktop. I have a question: If you have c

D15591: Add Open Document thumbnailer

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OK then! :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg, ngraham, kossebau Cc: kossebau, jtamate, ngraham

D15591: Add Open Document thumbnailer

broulik added a comment. > Does this thumbnailer ask for password for password protected files, No. I don't know how a password-protected document work but if it's encrypted like a ZIP file the file will just fail to open and generate, like you cannot open an encrypted file in `zip:/` KI

D15591: Add Open Document thumbnailer

ngraham added a reviewer: kossebau. ngraham added a subscriber: kossebau. ngraham added a comment. Hmm, looks like Calligra already has code that does some of this: https://cgit.kde.org/calligra.git/tree/extras/thumbnail/calligracreator.cpp. Ideally we would have the thumbnailer for these

D15591: Add Open Document thumbnailer

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, yeah, we need to make sure to not even try to generate thumbnails for password-protected files. Good catch, @jtamate REPOSITORY R320 KIO Extras REVISION DETAIL https:/

D15591: Add Open Document thumbnailer

jtamate added a comment. I haven't tested it, therefore I ask: Does this thumbnailer ask for password for password protected files, like in https://bugs.kde.org/show_bug.cgi?id=394284 ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #framewor

D15591: Add Open Document thumbnailer

ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg Cc: ngraham

D15591: Add Open Document thumbnailer

ngraham accepted this revision as: VDG. ngraham added a comment. Wow, that's pretty simple. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15591 To: broulik, #frameworks, #vdg Cc: ngraham

D15591: Add Open Document thumbnailer

broulik created this revision. broulik added reviewers: Frameworks, VDG. broulik requested review of this revision. REVISION SUMMARY Provides thumbnails for ODT, ODS, ODP, ODG, ODF files as well as their template counterparts TEST PLAN Some code I had written a while ago, not knowing there a