D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread Valeriy Malov
This revision was automatically updated to reflect the committed changes. Closed by commit R295:cc4ecfdcd48a: Manually resize KCMUtilDialog to sizeHint() (authored by valeriymalov). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15406?vs=41344&id=41446 REVIS

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread Andrew Crouthamel
acrouthamel added a comment. I've tested this patch on my system. Although it does not resolve the scaling issue I experience, it does not cause any regressions I see. Ship it! :) REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D15406 To: valeriymal

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread David Edmundson
davidedmundson added a comment. > neither QWidget::adjustSize() nor QWidget::adjustedSize() seem to use devicePixelRatio They shouldn't. Both qwidget sizes and qscreen sizes are in logical pixels. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread Andrew Crouthamel
acrouthamel added a comment. In D15406#324063 , @ngraham wrote: > @acrouthamel, could you test this patch to make sure it doesn't regress anything for High DPI users? I can test it out tonight. REPOSITORY R295 KCMUtils BRANCH master

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread Nathaniel Graham
ngraham added a comment. @acrouthamel, could you test this patch to make sure it doesn't regress anything for High DPI users? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D15406 To: valeriymalov, #frameworks, ngraham Cc: acrouthamel, kde-framewor

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread Valeriy Malov
valeriymalov added a comment. neither `QWidget::adjustSize()` nor `QWidget::adjustedSize()` seem to use `devicePixelRatio` (https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/kernel/qwidget.cpp#n8665), but I can't test that to vouch that it works on HiDPI as intended I can land it as i

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Awesome. Tested it out, and this definitely helps for 1366x768. Doesn't regress the 1920x1090 or larger case, either. To get High DPI support working, I bet we need to multiply some o

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-10 Thread Valeriy Malov
valeriymalov created this revision. valeriymalov added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. valeriymalov requested review of this revision. REVISION SUMMARY Workaround for https://bugreports.qt.io/browse/QTBUG-3459