jtamate planned changes to this revision.
jtamate added a comment.
QTest::qWaitForWindowActive fails because I use kwin Focus stealing
prevention High, therefore the windows doesn't become active until I click on
them in the task bar or switch to them.
And qWaitForWindowExposed doesn't help
jtamate updated this revision to Diff 43106.
jtamate added a comment.
Fix a crash ,caused by a still connected signal, after running again the
unittests.
kfilewidgettest still doesn't pass because QTest::qWaitForWindowActive fails
for me.
Don't accept this revision until kfilewidgettes
jtamate updated this revision to Diff 41246.
jtamate added a comment.
Use nullptr instead of 0.
Remove the copied/pasted part of the cause of two dissconnects.
@bruns, as I'm not sure if the code emits other signals for lineEdit, I
prefer to keep it as it was.
REPOSITORY
R241 KIO
CH
bruns added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfilewidget.cpp:1225
> QObject::disconnect(m_connEditTextChanged);
> m_connEditTextChanged = QMetaObject::Connection();
Me neither ...
But me wonders if this should not use `{QSignalBlocker(locationEdit); ...}`
instead.
jtamate updated this revision to Diff 41150.
jtamate marked an inline comment as done.
jtamate added a comment.
Changed to 'Anonymous' connects and disconnects.
Even if the documentation say: use 0 as a wildcard, the compiler thinks it
should be a nullptr
kfilewidget.cpp:1222:74: war
jtamate marked an inline comment as done.
jtamate added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfilewidget.cpp:1225
> QObject::disconnect(m_connEditTextChanged);
> m_connEditTextChanged = QMetaObject::Connection();
I'm sorry, but I still don't get it.
Doesn't connect/disc
anthonyfieroni added inline comments.
INLINE COMMENTS
> jtamate wrote in kfilewidget.cpp:1225
> I'm sorry but I don't understand your comment.
> m_connEditTextChanged is created in the constructor, line 585.
> Afterwards it is disconnected and reconnected in:
> setDummyHistoryEntry, removeDummyHi
jtamate added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfilewidget.cpp:1225
> Whenever disconnect after that reset connection to QMetaObject::Connection
> cause disconnect empty connection is safe, double disconnect same one - does
> not.
I'm sorry but I don't understand your
anthonyfieroni added inline comments.
INLINE COMMENTS
> kfilewidget.cpp:1225
> // the KDirOperator's view-selection in there
> -QObject::disconnect(locationEdit, SIGNAL(editTextChanged(QString)),
> -q, SLOT(_k_slotLocationChanged(QString)));
> +QObject::discon
jtamate updated this revision to Diff 41148.
jtamate marked 2 inline comments as done.
jtamate added a comment.
Changed [&] by [this]in the lambdas.
Added a lambda for KActionCollection::addAction. I didn't knew it was already
possible.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
htt
broulik added inline comments.
INLINE COMMENTS
> kfilewidget.cpp:440
> +connect(d->ops, &KDirOperator::urlEntered, this,
> +[&](const QUrl &url){d->_k_urlEntered(url);});
> +connect(d->ops, &KDirOperator::fileHighlighted, this,
Shouldn't this be using the `url` from the signa
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.
REVISION SUMMARY
Convert from the old syntax to the new connect syntax
TEST PLAN
The open
12 matches
Mail list logo
