cullmann added a comment.
Documentation updated.
The regressions for highlightings outside the repo should be minimal, as we
just ignore the suffix rules.
REPOSITORY
R40 Kate
REVISION DETAIL
https://phabricator.kde.org/D15219
To: cullmann, vkrause, dhaumann
Cc: kde-doc-english, kwrite
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R40:8f32f2df2d7f: remove child rule description, no longer
supported (authored by cullmann).
Herald added a project: Documen
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:376311622d37: forbid sub-rules (authored by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
cullmann reopened this revision.
cullmann added a comment.
Need to update the docs.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D15219
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsk
cullmann added a comment.
I will push this + adapt the kate.git docs for it.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D15219
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, cu
vkrause added a comment.
no objections to the idea, should indeed simplify things
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D15219
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demskin
cullmann updated this revision to Diff 40860.
cullmann added a comment.
converted all highlightings to use contexts instead of sub-rules
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15219?vs=40859&id=40860
BRANCH
master
REVISION DETAIL
h
cullmann updated this revision to Diff 40859.
cullmann added a comment.
more sub-rules replaced with contexts
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15219?vs=40857&id=40859
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/
cullmann updated this revision to Diff 40862.
cullmann added a comment.
remove sub-rules support
now we do all things just with flat rules + flat contexts
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15219?vs=40860&id=40862
BRANCH
mast
cullmann added a comment.
::load will skip over no longer supported sub-rules, beside minimal breakage
for non-shipped hls, all should be fine (the suffixes will lack HL)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D15219
To: cullmann, vkrause, dhauma
cullmann added a comment.
Done with all shipped things.
make && make test still works
Code is nicer, no nesting, we just can call doMatch, that btw. saves again
3-4% of overhead of ::match.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D15219
cullmann updated this revision to Diff 40863.
cullmann added a comment.
fix comments in schema, no child rules
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15219?vs=40862&id=40863
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.
REVISION SUMMARY
sub-rules are a hassle
they are only allowed for i
13 matches
Mail list logo
