This revision was automatically updated to reflect the committed changes.
Closed by commit R290:b42973d964df: Emit signals when a package is
installed/uninstalled (authored by davidedmundson).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15177?vs=40725&id=4
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in packagejob.cpp:90
> Can this be invalid or does `install` already check for validity?
bool PackageJobThread::installPackage(const QString &src, const QString &dest,
OperationType operation)
{
...
if (!meta.isValid()) {
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15177
To: davidedmundson, #plasma, broulik
Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns
broulik added inline comments.
INLINE COMMENTS
> packagejob.cpp:90
> +if (ok) {
> +const QString pluginId = d->package->metadata().pluginId();
> +const QStringList serviceTypes =
> d->package->metadata().serviceTypes();
Can this be invalid or does `install` alrea
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in packagejob.cpp:93
> Can `packageType` contain characters not allowed in DBus?
Technically, yes, it's a string in the metadata of the package type so could.
By convention format X-KDE-ServiceTypes is always in the format Fo
broulik added a comment.
+1
INLINE COMMENTS
> packagejob.cpp:93
> +for (auto packageType: serviceTypes) {
> +auto msg =
> QDBusMessage::createSignal(QStringLiteral("/KPackage/") + packageType,
> QStringLiteral("org.kde.plasma.kpackage"),
> QStringLiteral("packag
Zren added a dependent revision: D12040: Add wallpaperplugin.knsrc + QML
function to open GHNS dialog.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D15177
To: davidedmundson, #plasma
Cc: Zren, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This is needed for situations such as Plasma reloading the wallpa
