This revision was automatically updated to reflect the committed changes.
Closed by commit R296:abfc94c6093a: make push/pop part of ConfigModule API
(authored by mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D15098?vs=40701&id=43276#toc
REPOSITORY
R296 KDeclarative
CHANGES SINC
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
arcpatch-D15098
REVISION DETAIL
https://phabricator.kde.org/D15098
To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bru
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in configmodule.h:392
> I don't understand this sentence. It contains two "when"s
hopefully simpler comment
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D15098
To: mart, #plasma
Cc: davidedmunds
mart updated this revision to Diff 40701.
mart marked an inline comment as done.
mart added a comment.
- hopefully clearer comment
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15098?vs=40499&id=40701
BRANCH
arcpatch-D15098
REVISION DETAIL
https
davidedmundson added inline comments.
INLINE COMMENTS
> configmodule.cpp:170
>
> d->_qmlObject->setSource(QUrl::fromLocalFile(package.filePath("mainscript")));
> -
> d->_qmlObject->engine()->rootContext()->setContextProperty(QStringLiteral("kcm"),
> this);
> +
> d->_qml
mart added a reviewer: Plasma.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D15098
To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.
REVISION SUMMARY
for better separation, abstract push/pop and columnWidth in the ConfigModule
class so
the qml part won't have access to App
