D14955: Move example from techbase to own repo

This revision was automatically updated to reflect the committed changes. Closed by commit R311:87a84ac866c5: Move example from techbase to own repo (authored by ochurlaud). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14955?vs=40090&id=40093 REVISION DETAI

D14955: Move example from techbase to own repo

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir, dfaure Cc: dfaure, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham,

D14955: Move example from techbase to own repo

dfaure added a comment. +1, OK, this works for me. Simpler indeed. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir, dfaure Cc: dfaure, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14955: Move example from techbase to own repo

ochurlaud marked 4 inline comments as done. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir, dfaure Cc: dfaure, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14955: Move example from techbase to own repo

ochurlaud updated this revision to Diff 40090. ochurlaud added a comment. Added Licence, made it compile within the whole project and fix issues raised by dfaure. I think we shouldn't care about making the example self-standing. It's aimed at tutoring people to use the lib, not ECM nor C

D14955: Move example from techbase to own repo

dfaure added a comment. (or maybe the wiki was explicit about what the license was?) REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir, dfaure Cc: dfaure, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14955: Move example from techbase to own repo

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. And yes this needs a license, obviously. If the original author(s) can't be reached anymore, that means rewriting the example :( INLINE COMMENTS > CMakeLists.txt:3 > + > +find_pa

D14955: Move example from techbase to own repo

dfaure added a comment. Yes this needs to be compiled so it doesn't rot. The solution is obviously not add_subdirectory since that wouldn't catch missing find_packages etc. One way is to have cmake run cmake, like ki18n/autotests/CMakeLists.txt does to run cmake on the ki18n_install su

D14955: Move example from techbase to own repo

aacid added a comment. In D14955#312287 , @ochurlaud wrote: > In D14955#312279 , @aacid wrote: > > > -1 > > > > The example is not getting compiled it will rot > > > I'm not sure to underst

D14955: Move example from techbase to own repo

ochurlaud added a comment. In D14955#312279 , @aacid wrote: > -1 > > The example is not getting compiled it will rot I'm not sure to understand: it *can* be compiled, whereas on the current status (in the wiki) it will never be ! Mayb

D14955: Move example from techbase to own repo

aacid added a comment. -1 The example is not getting compiled it will rot REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14955: Move example from techbase to own repo

elvisangelaccio added a comment. +1 Do we need a license for the example source files? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14955: Move example from techbase to own repo

ochurlaud added reviewers: Frameworks, valir. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14955: Move example from techbase to own repo

ochurlaud created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ochurlaud requested review of this revision. REVISION SUMMARY Add example based on https://techbase.kde.org/Development/Tutorials/KWallet so that it can be kept up-to-date. The