This revision was automatically updated to reflect the committed changes.
Closed by commit R216:612343c96543: handle context switch attributes of the
contexts themself (authored by cullmann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14952?vs=40067&id=40158#toc
REPOSITORY
R216 Syn
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
I got told that I missed some more ContextSwitch variants.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14952
To: cullmann, vkrause, dhaumann
Cc
cullmann added a comment.
If we want a nice order, we should sort them at the end like the repo does.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14952
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevin
dhaumann added a comment.
Looks ok to me. Only thing is: with takeLast() you now changed the order of
the IncludedDefinitions compared to the previous version. This is of course ok,
but in the color config dialog the order is now different than before. Whatever
this means... I liked that Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9cfb8fa9a684: Fix includedDefinitions, handle definition
change in context switch… (authored by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
ngraham edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14952
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew,
ngraham, bruns, demsking, cullmann, vkrause, sars, d
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14952
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew,
ngraham, bruns,
cullmann added a comment.
kate *.* in the autotests/input folder works now without any crash, too.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14952
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapa
cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
cullmann added projects: Framework: Syntax Highlighting, Frameworks.
Herald added a project: Kate.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.
REVISION SUMMARY
