D14733: [KFormat] Add human readble list displaying function

safaalfulaij added a comment. In D14733#306325 , @bruns wrote: > You should start with > a) a use case > b) show it actually matches the needs of different languages. > > For e.g. englisch and the most european languages, two different p

D14733: [KFormat] Add human readble list displaying function

safaalfulaij updated this revision to Diff 39425. safaalfulaij added a comment. Fix test No unrelated changes REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14733?vs=39418&id=39425 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14733

D14733: [KFormat] Add human readble list displaying function

bruns added inline comments. INLINE COMMENTS > kformattest.cpp:396 > + > +QStringList testDate; > +QCOMPARE(format.formatList(testDate), QStringLiteral("")); Why test**Date**? > kformat.h:287 > * > - * e.g. given formatDuration(6), returns "1.0 minutes" > + * e.g. give

D14733: [KFormat] Add human readble list displaying function

bruns added a comment. You should start with a) a use case b) show it actually matches the needs of different languages. For e.g. englisch and the most european languages, two different positions are sufficent. Also, the AndListType and the UnitListType are identical. What is missing

D14733: [KFormat] Add human readble list displaying function

safaalfulaij added a comment. Tbh I don't fully understand the `struct` and `find` statments (just saw working similar code and edited-copy-pasted). I prefer if someone can continue this instead of me. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14733 To: s

D14733: [KFormat] Add human readble list displaying function

safaalfulaij created this revision. safaalfulaij added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. safaalfulaij requested review of this revision. REVISION SUMMARY Add formatList() to convert QString