This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e7c7184209c5: Use in-class member initialization where
possible (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14499?vs=38808&id
dhaumann added a comment.
Yes, only private classes were changed intentionally. Public classes don't
have members anyways besides the d-pointer. And the d-pointer requires a
non-trivial constructor/destructor.
REPOSITORY
R216 Syntax Highlighting
BRANCH
useMemberInit (branched from maste
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.
Moving a default ctor/dtor definition to the header would break ABI for
exported classes, but this seems to only touch non-exported ones, so this
should be fine.
REPOSITORY
R216 Syntax
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.
REVISION SUMMARY
Allows to default some construct