D14397: Port audio notification to libcanberra

2018-07-26 Thread Nathaniel Graham
ngraham added a comment. Impressive work, Kai! However I rather like the idea of improving QTMultiMedia's sound handling features rather than working around the lack of them by using a different library. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397

D14397: Port audio notification to libcanberra

2018-07-26 Thread René J . V . Bertin
rjvbb added a comment. Anyway, if using QtMultiMedia cannot be considered please make it a build option to use just QApplication::beep() for sound notifications so that packagers can decide whether or not they want to introduce dependencies on libcanberra and everything it needs. On Mac at l

D14397: Port audio notification to libcanberra

2018-07-26 Thread René J . V . Bertin
rjvbb added a comment. That's a nicety, not necessarily a requirement, at least not for playing notification sounds. Just how often do you get sound alerts at such high rates that caching becomes unavoidable, before you get mad and resolve the issue or yank the plug? I think that proper cros

D14397: Port audio notification to libcanberra

2018-07-26 Thread Harald Sitter
sitter added a comment. In D14397#298420 , @rjvbb wrote: > > According to its website "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)" > > Which are all either Linux-specific or *nix-desktop oriented with ties to

D14397: Port audio notification to libcanberra

2018-07-26 Thread Harald Sitter
sitter added a comment. In D14397#298420 , @rjvbb wrote: > I didn't think of this before, but do you actually need a 3rd party library for playing alert sounds? In D14397#298350 , @sitter w

D14397: Port audio notification to libcanberra

2018-07-26 Thread René J . V . Bertin
rjvbb added a comment. > According to its website "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)" Which are all either Linux-specific or *nix-desktop oriented with ties to X11 and probably even GTk. Justifying a change with loss of weight while at the sa

D14397: Port audio notification to libcanberra

2018-07-26 Thread Kai Uwe Broulik
broulik added a comment. > Does libcanberra (still) require pulseaudio or can it work with different backends? According to its website "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)" REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.

D14397: Port audio notification to libcanberra

2018-07-26 Thread René J . V . Bertin
rjvbb added a comment. > - gstreamer is technically x-platform, whether one actually wants to attempt building and using it on these platforms is another question I suppose Gstreamer builds and functions on Mac, but AFAIK comes with a whole bunch of dependencies to install and run. REPO

D14397: Port audio notification to libcanberra

2018-07-26 Thread René J . V . Bertin
rjvbb added a comment. > We probably lose the ability to play sound on Windows and Mac? Does libcanberra (still) require pulseaudio or can it work with different backends? It not, a move to using it exclusively for sound would get a big fat -1 from me. Pulseaudio is problematic on Mac

D14397: Port audio notification to libcanberra

2018-07-26 Thread Harald Sitter
sitter added a comment. Canberra's primary advantage over phonon is that it can directly use pulseaudio/alsa, bypassing the entire sound system middleware madness and leveraging PA's builtin caching mechanism. i.e. if a sound notification is played a bunch of times it will be cached in-betwe

D14397: Port audio notification to libcanberra

2018-07-26 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMAR