This revision was automatically updated to reflect the committed changes.
Closed by commit R495:0c9bf25e18a8: Add bluetooth plugin (authored by
nicolasfella).
REPOSITORY
R495 Purpose Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14052?vs=37583&id=37969
REVISION DETAIL
htt
apol added a comment.
Yes, I can reproduce too. `qmlplugindump-qt5 org.kde.bluezqt 1.0` returns 2
for some reason. Will have to investigate.
Land this for now if you want.
REPOSITORY
R495 Purpose Library
BRANCH
bluetooth
REVISION DETAIL
https://phabricator.kde.org/D14052
To: nic
nicolasfella added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:1
> Maybe should have `find_qmlmodule(org.kde.bluezqt 1.0)`?
Makes sense.
When I include it cmake tells me it's not found, although
/usr/lib/qt/qml/org/kde/bluezqt exists. Am I missing something?
REPOSITORY
R
apol accepted this revision.
apol added a comment.
LGTM overall.
INLINE COMMENTS
> CMakeLists.txt:1
> +add_share_plugin(bluetoothplugin bluetoothplugin.cpp)
Maybe should have `find_qmlmodule(org.kde.bluezqt 1.0)`?
REPOSITORY
R495 Purpose Library
BRANCH
bluetooth
REVISION DETAIL
http
nicolasfella added a comment.
@apol I would like your opinion before merging
REPOSITORY
R495 Purpose Library
BRANCH
bluetooth
REVISION DETAIL
https://phabricator.kde.org/D14052
To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Looks great and works great!
REPOSITORY
R495 Purpose Library
BRANCH
bluetooth
REVISION DETAIL
https://phabricator.kde.org/D14052
To: nicolasfella, apol, ngraham
Cc: kde-frameworks
nicolasfella added a dependent revision: D14056: Remove FileItemActionPlugin in
favor of Purpose plugin.
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D14052
To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
nicolasfella updated this revision to Diff 37583.
nicolasfella added a comment.
- Revert unintended change
REPOSITORY
R495 Purpose Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14052?vs=37582&id=37583
BRANCH
bluetooth
REVISION DETAIL
https://phabricator.kde.org/D140
nicolasfella created this revision.
nicolasfella added reviewers: apol, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
Replace Bluedevil's FileItemActio
