This revision was automatically updated to reflect the committed changes.
Closed by commit R858:1e02355c1786: Support for QGuiApplication-based apps
(authored by rjvbb).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D14000?vs=44083&id=46108#toc
REPOSITORY
R858 Qt Quick Controls 2: Desk
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D14000
To: rjvbb, #frameworks, mart
Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel,
ZrenBo
rjvbb retitled this revision from "qqc2-desktop-style: basic support for
QGuiApplication-based apps (WIP/PoC)" to "qqc2-desktop-style: basic support for
QGuiApplication-based apps".
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D14000
To: rj
rjvbb set the repository for this revision to R858 Qt Quick Controls 2: Desktop
Style.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D14000
To: rjvbb, #frameworks
Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel,
Zr
rjvbb updated this revision to Diff 44083.
rjvbb added a comment.
updated for the current git/head.
David: did you perhaps forget to accept the revision (aka, should I have
committed this)?
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14000?vs=37897&id=44083
REVISION DETAIL
rjvbb updated this revision to Diff 37897.
rjvbb added a comment.
Using QApplication::style()
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14000?vs=37568&id=37897
REVISION DETAIL
https://phabricator.kde.org/D14000
AFFECTED FILES
plugin/kquickstyleitem.cpp
plugin/kquickstyle
rjvbb set the repository for this revision to R858 Qt Quick Controls 2: Desktop
Style.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D14000
To: rjvbb, #frameworks
Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel,
Zr
alexeymin added a comment.
Don't know how much offtopic will be what I'm going to say, but I recently
ran into an issue while packaging QQC2 application in flatpak with
org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system,
but under flatpak it failed to start with t
davidedmundson added a comment.
Please swap qApp->style for QApplication::style as it's static.
Solution is quite clever.
It's risky as any qstyle will always be written assuming it's a QApplication;
but by definition the QQC2 code shields from a lot of the QWidget casting that
would
rjvbb updated this revision to Diff 37568.
rjvbb added a comment.
build on Mac too
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14000?vs=37439&id=37568
REVISION DETAIL
https://phabricator.kde.org/D14000
AFFECTED FILES
plugin/kquickstyleitem.cpp
plugin/kquickstyleitem_p.h
T
rjvbb set the repository for this revision to R858 Qt Quick Controls 2: Desktop
Style.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D14000
To: rjvbb, #frameworks
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-moha
mart added a comment.
in principle i agree, I would love to be able to use this in
qguiapplications, but are we sure qstyles won't access qapplication? doesn't
this risk to just move the crash?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.or
broulik added a comment.
Why, or who, is setting this environment variable? Plasma-integration sets
`QQuickStyle` depending on whether there is a `QApplication` or not, so this
makes no sense.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org
rjvbb edited the summary of this revision.
rjvbb edited reviewers, added: Frameworks; removed: Framework: Syntax
Highlighting.
rjvbb set the repository for this revision to R858 Qt Quick Controls 2: Desktop
Style.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://ph
14 matches
Mail list logo
