This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d24a61cae282: Refactor udsentrytest (authored by jtamate).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13897?vs=37183&id=37199
REVISION DETAIL
https://phabricator.
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D13897
To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
jtamate updated this revision to Diff 37183.
jtamate added a comment.
Commas at the end.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13897?vs=37172&id=37183
REVISION DETAIL
https://phabricator.kde.org/D13897
AFFECTED FILES
autotests/udsentrytest.cpp
T
dfaure added a comment.
I'm not a big fan of the comma at the beginning of the line (without even a
space after the comma). Why not at end of line? I guess search-replace made
this way easier, but it doesn't really look good ;)
Try kde-dev-scripts's uncrustify script, it might reformat all
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.
REVISION SUMMARY
Use c++ initialization lists instead of <<.
