D13848: Fix device label with unknown size

2018-07-03 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R245:cc7760bd33e4: Fix device label with unknown size (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13848?vs=37063&id=37111 REVISION DETAIL http

D13848: Fix device label with unknown size

2018-07-03 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13848 To: broulik, davidedmundson Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D13848: Fix device label with unknown size

2018-07-02 Thread Kai Uwe Broulik
broulik added a comment. I have seen it do that for e.g. a Floppy that is not "present" (I fixed that independently from this patch to show "Floppy" again). I guess whenever an external media isn't present, like an SD card in a reader or so. REPOSITORY R245 Solid REVISION DETAIL https:/

D13848: Fix device label with unknown size

2018-07-02 Thread Stefan BrĂ¼ns
bruns added a comment. So the question is, on which occasion does solid return a size of 0? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13848 To: broulik, davidedmundson Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D13848: Fix device label with unknown size

2018-07-02 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `size_str` can never actually become empty as