D13757: Move parsing .desktop file for folder Comment to file KIO

broulik added a comment. Theres's also the directory icon reading which potentially blocks, so doing both in the KIO slave improves the situation without having to introduce new API and rewrite everything and the kitchen sink. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.

D13757: Move parsing .desktop file for folder Comment to file KIO

broulik abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13757 To: broulik, dfaure, lbeltrame Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13757: Move parsing .desktop file for folder Comment to file KIO

dfaure added a comment. The problem is that now this is done for every single file being listed, rather than on demand. In a directory with 1000 subdirs, this would look for 1000 */.directory files, while the user is typically only going to hover one or two... I agree that blocking a differe

D13757: Move parsing .desktop file for folder Comment to file KIO

ngraham added a comment. Would this be a satisfactory way to also read a custom icon from the .directory file? If you add that, I'll be happy to abandon D13083: Respect custom directory icons in iconNameForURL() . REPOSITORY R241 KIO REVISION DETAIL h

D13757: Move parsing .desktop file for folder Comment to file KIO

broulik retitled this revision from "Move parsing .desktop file for Comment to file KIO" to "Move parsing .desktop file for folder Comment to file KIO". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13757 To: broulik, dfaure, lbeltrame Cc: kde-frameworks-devel, michaelh,