D13559: Fix some of cppcheck warnings

2018-07-04 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R127:84bc3cbd6102: Fix some of cppcheck warnings (authored by bshah). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=37088&id=37135 REVISION DETAIL https://

D13559: Fix some of cppcheck warnings

2018-07-03 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH fix-cppcheck REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks, aacid Cc: apol, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13559: Fix some of cppcheck warnings

2018-07-02 Thread Bhushan Shah
bshah added subscribers: aacid, apol. bshah added a comment. Added subscribers back which arc removed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: apol, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13559: Fix some of cppcheck warnings

2018-07-02 Thread Bhushan Shah
bshah updated this revision to Diff 37088. bshah edited the summary of this revision. bshah removed subscribers: aacid, apol. bshah added a comment. update commit message REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=37087&id=37088 BRANCH fix-

D13559: Fix some of cppcheck warnings

2018-07-02 Thread Bhushan Shah
bshah updated this revision to Diff 37087. bshah added a comment. - fix memory leak properly REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=36199&id=37087 BRANCH fix-cppcheck REVISION DETAIL https://phabricator.kde.org/D13559 AFFECTED FILES

D13559: Fix some of cppcheck warnings

2018-07-02 Thread Albert Astals Cid
aacid added a comment. In D13559#285836 , @bshah wrote: > In D13559#285804 , @apol wrote: > > > I don't see any fix here. It's just silencing cppcheck. > > > Only supressing done is the memleak

D13559: Fix some of cppcheck warnings

2018-07-02 Thread Bhushan Shah
bshah added a comment. In D13559#285804 , @apol wrote: > I don't see any fix here. It's just silencing cppcheck. Only supressing done is the memleak in the autotests, otherwise for selfInitialization it is the false alarm, which can be fi

D13559: Fix some of cppcheck warnings

2018-07-01 Thread Aleix Pol Gonzalez
apol added a comment. I don't see any fix here. It's just silencing cppcheck. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13559: Fix some of cppcheck warnings

2018-07-01 Thread Bhushan Shah
bshah added a comment. bump? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13559: Fix some of cppcheck warnings

2018-06-15 Thread Bhushan Shah
bshah created this revision. bshah added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - selfInitialization - memleak I could probably s