This revision was automatically updated to reflect the committed changes.
Closed by commit R304:d659619e0c96: Remove KNS::Engine d-pointer hack (authored
by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13515?vs=36098&id=36105
REVISION DETAIL
http
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
this is binary compatible from what I can see
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13515
To: apol, #frameworks, leinir, mwolff
Cc: mw
leinir added a comment.
H... this is tricky, but... yes, it seems reasonable to me that replacing
one pointer with another would cause no BIC issues... and i certainly am happy
to get rid of the d-pointer hack, so... if we're absolutely super-sure that
this is BC, i'm all for it... would
apol created this revision.
apol added reviewers: Frameworks, leinir.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
Put one of the pointers in KNS::Engine in the d-poin
