davidedmundson added a comment.
It was an exported symbol, but the relevant header was never exposed
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13488
To: davidedmundson, #plasma, romangg
Cc: rikmills, romangg, kde-frameworks-devel, michaelh, ngraham, bruns
rikmills added a comment.
In libkf5waylandclient5 and libkf5waylandserver5 I see the previously emitted
symbol xdg_shell_interface@Base is now reported as MISSING.
Can you confirm this is private and/or not an ABI break?
Build symbols output: https://paste.kde.org/pfpkps1mb#line-109
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:63bd1f441644: Make XDGShellV5 co-compilable with
XDGWMBase (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13488?vs=37034&id=37871
RE
romangg accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13488
To: davidedmundson, #plasma, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson updated this revision to Diff 37034.
davidedmundson added a comment.
update
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13488?vs=36029&id=37034
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13488
AFFECTED FILES
src/c
davidedmundson added a dependent revision: D13530: Add XDG WmBase support.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13488
To: davidedmundson, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
romangg added inline comments.
INLINE COMMENTS
> xdgshell_v5.cpp:36
> public:
> -void setupV5(xdg_shell *shell) override;
> +void setupV5(xdg_shell *shell);
> void release() override;
This should be still an override.
> wayland-xdg-shell-v5-client-protocol.h:1
> +/* Generated by w
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
When we add WMBase (the new name
