This revision was automatically updated to reflect the committed changes.
Closed by commit R275:4b1e1b44ef9f: Add new class that is a model of numbers
between two values (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D13358?vs=35681&id=69812#toc
REPOSITORY
vkrause added a comment.
ping? this is needed for scratch/davidedmundson/kirigami-addons
REPOSITORY
R275 KItemModels
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13358
To: davidedmundson, vkrause
Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R275 KItemModels
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13358
To: davidedmundson, vkrause
Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson updated this revision to Diff 35681.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.
Most review comments
As for the locale enum, I'm not sure.
I'm working on a QML module and I'm trying to resolve any QML specific issues
there rather
davidedmundson marked 11 inline comments as done.
davidedmundson added a comment.
> In all the documentation blocks you miss the argument and return value
documentation.
Are there any instances where that would provide any added value?
INLINE COMMENTS
> broulik wrote in knumbermodeltest
broulik added a comment.
Just saw I forgot to submit those comments yesterday
INLINE COMMENTS
> knumbermodeltest.cpp:26
> +QCOMPARE(m.rowCount(), 3);
> +QCOMPARE(m.data(m.index(0, 0), Qt::DisplayRole), QVariant("3"));
> +QCOMPARE(m.data(m.index(1, 0), Qt::DisplayRole),
davidedmundson added a comment.
For any C++ project you're right that you'd use that or even a basic for loop
instead of a model.
But when writing declaratively means we shouldn't be doing programatic lopos.
For a KDE project I wanted a QtQuickControls2 Tumbler to show year selection
markg added a comment.
This basically is the equivalent of the C++ range iterator
(https://github.com/ryanhaining/cppitertools#range, but more libraries have a
"range" iterator like that).
In all the documentation blocks you miss the argument and return value
documentation.
I'm cur
davidedmundson edited the summary of this revision.
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D13358
To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
In QML a lot of code is built up on list models.
One thing I found is
10 matches
Mail list logo