D13285: FrameSVG: Use QMargins

2018-06-03 Thread Vlad Zagorodniy
zzag added a comment. I'm not sure whether that's a good idea to use QMargins for measures, maybe, it would be better to have something like struct { QSize left; QSize top; QSize right; QSize bottom; } sizes, fixedSizes; in FrameData, which then

D13285: FrameSVG: Use QMargins

2018-06-03 Thread Vlad Zagorodniy
zzag abandoned this revision. zzag added a comment. The diff is crap. I'll abandon it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13285 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13285: FrameSVG: Use QMargins

2018-06-03 Thread Vlad Zagorodniy
zzag updated this revision to Diff 35453. zzag added a comment. Fix ::margins() and ::fixedMargins() REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13285?vs=35444&id=35453 BRANCH framesvg-modernize REVISION DETAIL https://phabricato

D13285: FrameSVG: Use QMargins

2018-06-03 Thread Vlad Zagorodniy
zzag updated this revision to Diff 35444. zzag added a comment. Forward-declare QMarginsF. (to be consistent with QRectF, QSizeF, etc) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13285?vs=35412&id=35444 BRANCH framesvg-modernize RE

D13285: FrameSVG: Use QMargins

2018-06-02 Thread Vlad Zagorodniy
zzag created this revision. zzag added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY Use QMargins to store margins and measures. As a sid