D13191: [server] Small code cleanup in SurfaceInterface

2018-06-10 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R127:31b1c144fde7: [server] Small code cleanup in SurfaceInterface (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13191?vs=35095&id=35957 REVISI

D13191: [server] Small code cleanup in SurfaceInterface

2018-06-04 Thread Roman Gilg
romangg edited the summary of this revision. REPOSITORY R127 KWayland BRANCH surfaceCodeCleanup REVISION DETAIL https://phabricator.kde.org/D13191 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D13191: [server] Small code cleanup in SurfaceInterface

2018-06-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH surfaceCodeCleanup REVISION DETAIL https://phabricator.kde.org/D13191 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, b

D13191: [server] Small code cleanup in SurfaceInterface

2018-05-29 Thread Roman Gilg
romangg added a comment. In D13191#270177 , @davidedmundson wrote: > > function definitions in correct order. > > What's more correct about this order? In surface_interface_p.h the functions are declared in this order: void ins

D13191: [server] Small code cleanup in SurfaceInterface

2018-05-29 Thread David Edmundson
davidedmundson added a comment. > function definitions in correct order. What's more correct about this order? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13191 To: romangg, #plasma Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D13191: [server] Small code cleanup in SurfaceInterface

2018-05-29 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Use lambda function to reduce code duplication and put