D13120: fix i18n issues in framworks/purpose/plugins

2018-05-27 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R495:6ff87ba74f80: fix i18n issues in framworks/purpose/plugins (authored by lueck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13120?vs=34875&id=34964#toc REPOSITORY R495 Purpose Library CH

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-26 Thread Albert Astals Cid
aacid added a comment. if there's other places using the backslash it's fine, no need to change :) REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13120 To: lueck, #frameworks, #localization, nicolasfella, apol Cc: aacid, apol, kde-frameworks-devel, michaelh,

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-26 Thread Burkhard Lück
lueck added a comment. In D13120#268343 , @aacid wrote: > Are you sure you need the backslashes in add_definitions? probably not. i simply used what is used in the majority of all modules (frameworks, workspace, kde*, pim), except okula

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-25 Thread Albert Astals Cid
aacid added a comment. Are you sure you need the backslashes in add_definitions? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13120 To: lueck, #frameworks, #localization, nicolasfella, apol Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-25 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13120 To: lueck, #frameworks, #localization, nicolasfella, apol Cc: apol, kde-frameworks-devel, michael

D13120: fix i18n issues in framworks/purpose/plugins

2018-05-25 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Frameworks, Localization, nicolasfella. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. lueck requested review of this revision. REVISION SUMMARY add missing TRANSLATION_DOMAI