D13092: make sure paths in rcc are never derived from absolute paths

This revision was automatically updated to reflect the committed changes. Closed by commit R290:2fdbbf13a6d5: make sure paths in rcc are never derived from absolute paths (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13092?vs=34807&id=348

D13092: make sure paths in rcc are never derived from absolute paths

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH phab/properrccpath REVISION DETAIL https://phabricator.kde.org/D13092 To: mart, #plasma, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13092: make sure paths in rcc are never derived from absolute paths

mart marked an inline comment as done. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D13092 To: mart, #plasma Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13092: make sure paths in rcc are never derived from absolute paths

mart added a comment. In D13092#267702 , @apol wrote: > Don't we have to make sure path is relative to the package root? at this point we already know that absolute path is correct (regarding the actual filesystem), under defaultpackagero

D13092: make sure paths in rcc are never derived from absolute paths

mart updated this revision to Diff 34807. mart added a comment. - e midRef REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13092?vs=34803&id=34807 BRANCH phab/properrccpath REVISION DETAIL https://phabricator.kde.org/D13092 AFFECTED FILES src/kpack

D13092: make sure paths in rcc are never derived from absolute paths

apol added a comment. Don't we have to make sure path is relative to the package root? INLINE COMMENTS > package.cpp:554 > +//we need just the plugin name here, never the absolute path > +dir = QDir(QStringLiteral(":/") + defaultPackageRoot() + > path.mid(path.lastInd

D13092: make sure paths in rcc are never derived from absolute paths

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY the paths for rcc plasmoids are always in the form :/plasma/p