apol added a comment.
Yep, this was from the old and deprecated modeltest.cpp.
I'll have to look into how to do it right :P
REPOSITORY
R275 KItemModels
REVISION DETAIL
https://phabricator.kde.org/D13043
To: apol, #frameworks, broulik
Cc: dfaure, broulik, kde-frameworks-devel, michae
dfaure added a comment.
BTW, the commit message refers to ModelTest, but that's the old
modeltest.cpp, not the new QAbstractItemModelTester, right?
I'm working on QConcatenateTablesProxyModel
(https://codereview.qt-project.org/166323) and there QAbstractItemModelTester
passes with asser
This revision was automatically updated to reflect the committed changes.
Closed by commit R275:958e7c9c56d9: Properly sanitize input (authored by apol).
REPOSITORY
R275 KItemModels
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13043?vs=34858&id=35111
REVISION DETAIL
https://phabr
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R275 KItemModels
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13043
To: apol, #frameworks, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
apol marked 3 inline comments as done.
apol added inline comments.
INLINE COMMENTS
> broulik wrote in kconcatenaterowsproxymodel.cpp:112
> You can also use `{}` here, no? Also, I would prefer an early return rather
> than unary operator
No, the ternary operator doesn't allow using {} saying it
apol updated this revision to Diff 34858.
apol marked 2 inline comments as done.
apol added a comment.
address kai's remarks
REPOSITORY
R275 KItemModels
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13043?vs=34659&id=34858
BRANCH
master
REVISION DETAIL
https://phabricator.k
broulik added inline comments.
INLINE COMMENTS
> kconcatenaterowsproxymodel.cpp:70
> const QAbstractItemModel *sourceModel = sourceIndex.model();
> +if (!sourceModel)
> +return {};
Coding style, braces also for single line statements
> kconcatenaterowsproxymodel.cpp:112
>
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
Helps to use it together with ModelTest
REPOSITORY
R275
