D12895: WIP: Add KFileItemActionsPlugin

broulik abandoned this revision. broulik added a comment. Superseded by D13124 REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12895 To: broulik, #plasma, #vdg, apol Cc: nicolasfella, elvisangelaccio, abetts, ngraham, kde-

D12895: WIP: Add KFileItemActionsPlugin

nicolasfella added inline comments. INLINE COMMENTS > sharefileitemaction.cpp:83 > +m_purposeMenu->model()->setInputData(QJsonObject{ > +{QStringLiteral("mimeType"), fileItemInfos.mimeType()}, > +{QStringLiteral("urls"), mimeType() can be empty which can cause problems (see D

D12895: WIP: Add KFileItemActionsPlugin

elvisangelaccio added inline comments. INLINE COMMENTS > purposefileitemaction.desktop:1-8 > +[Desktop Entry] > +Type=Service > +Name=Share file > +X-KDE-Library=purposefileitemaction > +X-KDE-Submenu=Share > +Icon=document-share > +ServiceTypes=KFileItemAction/Plugin Why not just starting with

D12895: WIP: Add KFileItemActionsPlugin

abetts added a comment. +1 REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12895 To: broulik, #plasma, #vdg, apol Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D12895: WIP: Add KFileItemActionsPlugin

ngraham added a comment. Fantastic! I've wanted this for so long! That "send as email attachment" item you have in your Dolphin context menu... is that a separate service item provided by KMail that will become obsolete with this new share menu? Seems kinda redundant to have them both...

D12895: WIP: Add KFileItemActionsPlugin

broulik created this revision. broulik added reviewers: Plasma, VDG, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows to share files from Dolphin's file co