vkrause added a comment.
That's probably due to me misunderstanding the intended/existing behavior
when implementing this, not an intentional decision in KSyntaxHighlighting.
Removing redundancy sounds like a good idea though.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://
dhaumann added a subscriber: cullmann.
dhaumann added a comment.
@vkrause @cullmann Could you please comment on the above? Should we change
KTextEditor such that dynamic is automatically derived based on whether there
is a dynamic rule? Indeed, I agree with @jpoelen that this is redundant.
R
jpoelen added a comment.
@dhaumann The difference is in the `dynamic` attribute of a context. Kate
propagates the captures only if the value is `true` whereas SyntaxHighlighting
never looks at that value and only uses the `dynamic` attribute of the rules.
Personally, I find that having t
dhaumann added a subscriber: vkrause.
dhaumann added a comment.
@jpoelen And why is it a problem with Kate? This means the C++ implementation
of the highlighting rules is different in KSyntaxHighlighting and KTextEditor?
If so, this would be an important catch. Can you elaborate why this is g
jpoelen added a comment.
There is indeed a problem with Kate, but it works with KSyntaxHighlighting. I
will look in what part of doxygenlua.xml the problem is.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D12689
To: jpoelen, dhaumann, #framework_syntax
dhaumann added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
@jpoelen Could you have a look at https://bugs.kde.org/show_bug.cgi?id=394184
? It seems we have a regression?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https
dhaumann closed this revision.
dhaumann added a comment.
Committed, see
https://commits.kde.org/syntax-highlighting/9f11b4fa2604c02e9a15f1949a8455283e9c0d62
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D12689
To: jpoelen, dhaumann, #framework_syntax_hi
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me. Please push.
REPOSITORY
R216 Syntax Highlighting
BRANCH
lua
REVISION DETAIL
https://phabricator.kde.org/D12689
To: jpoelen, dhaumann, #framework_syntax_highlig
jpoelen created this revision.
jpoelen added reviewers: dhaumann, Framework: Syntax Highlighting.
jpoelen added projects: Framework: Syntax Highlighting, Frameworks.
Restricted Application added a subscriber: Frameworks.
jpoelen requested review of this revision.
REVISION SUMMARY
Add of:
-
