D12647: Move the inline preview button into the menu

ngraham added a comment. Oops, sorry I missed your comments! Yes, removing it from the task description makes sense. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks Cc: meven, kde-frameworks-devel, anemeth, LeGast00n, michaelh, ngraham, br

D12647: Move the inline preview button into the menu

meven added a comment. In D12647#456283 , @meven wrote: > In D12647#434327 , @ngraham wrote: > > > I don't think this makes sense anymore. > > > "Put the Show Inline Preview button in the setti

D12647: Move the inline preview button into the menu

meven added a comment. In D12647#434327 , @ngraham wrote: > I don't think this makes sense anymore. "Put the Show Inline Preview button in the settings menu" is still in T8552 , shouldn't we remove this

D12647: Move the inline preview button into the menu

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12647: Move the inline preview button into the menu

ngraham abandoned this revision. ngraham added a comment. I don't think this makes sense anymore. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12647: Move the inline preview button into the menu

rkflx resigned from this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12647: Move the inline preview button into the menu

ngraham added a comment. Should we land this on the `file-dialog-improvements` branch, or are folks still unsure? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks, rkflx Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12647: Move the inline preview button into the menu

ngraham added a comment. Friendly ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks, rkflx Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12647: Move the inline preview button into the menu

ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Now that previews are on by default but not shown for small icons, are there any other objections to doing this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham,

D12647: Move the inline preview button into the menu

rkflx added a comment. In T8552#140332 , @rkflx wrote: > > moving the Show Preview button to the menu > > Makes sense to me, but might be controversial with others. FWIW, if people do not like this (e.g. because they often toggle previe

D12647: Move the inline preview button into the menu

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks, rkflx Cc: anemeth, michaelh, bruns

D12647: Move the inline preview button into the menu

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks, rkflx Cc: anemeth, michaelh, bruns

D12647: Move the inline preview button into the menu

ngraham created this revision. ngraham added reviewers: Frameworks, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Once previews are on by default and automatically disable themselves for small icon sizes, there's little re