D12544: Don't select file extension

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg, ngraham, rkflx, elvisangelaccio Cc: elvisangelaccio, rkflx, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

elvisangelaccio accepted this revision. REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg, ngraham, rkflx, elvisangelaccio Cc: elvisangelaccio, rkflx, ngraham, #frameworks, michaelh, bru

D12544: Don't select file extension

ngraham added a comment. Always nice to see a patch with more red than green in it. :) REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: elvisangelaccio, rkflx, n

D12544: Don't select file extension

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: elvisangelaccio, rkflx, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

anemeth updated this revision to Diff 33325. anemeth added a comment. Remove some comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12544?vs=33173&id=33325 BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.or

D12544: Don't select file extension

elvisangelaccio added inline comments. INLINE COMMENTS > kfilewidget.cpp:1290 > > // don't change selection when user has clicked on an item > +if (operationMode == KFileWidget::Saving) { This comment makes little sense to me. Since it was part of the same commit spotted by @rkflx (0

D12544: Don't select file extension

ngraham added a comment. Given that this is fixing a fairly straightforward bug, I feel pretty confident about this patch. #frameworks people: any objections, or shall we land this tomorrow? REPOSITORY R241 KIO BRANCH select_filename_only (

D12544: Don't select file extension

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

rkflx accepted this revision. rkflx added a comment. Thanks for the patch. Pondered over the code, but could not find anything wrong. In D12544#254554 , @anemeth wrote: > I removed these checks: `&& !locationEdit->isVisible()` > I assume

D12544: Don't select file extension

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. Looks like this does what it's supposed to for open and save, in both single and double-click mode. Tested with Kate, Spectacle, and Gwenview. REPOSITORY R241 KIO BRANCH select

D12544: Don't select file extension

anemeth added a comment. Turns out this was already implemented before, but was not currently utilized. These 3000+ lines files are hard to overwiev... I removed these checks: `&& !locationEdit->isVisible()` I assume at one point the filename line edit was once set to hide/show on demand

D12544: Don't select file extension

anemeth updated this revision to Diff 33173. anemeth added a comment. Only enable it for save dialog REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12544?vs=33162&id=33173 BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabrica

D12544: Don't select file extension

ngraham added a comment. In D12544#254467 , @anemeth wrote: > There will be some problems with files that have multiple extensions, for example .tar.gz or .tar.bz > We could create a list of the most common multiextension filetypes, but I onl

D12544: Don't select file extension

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Let's only enable this behavior for the Save dialogs. For the Open dialogs, it seems sensible that you'd actually want the whole text selected (but not focused, see D12545

D12544: Don't select file extension

anemeth added a comment. There will be some problems with files that have multiple extensions, for example .tar.gz or .tar.bz We could create a list of the most common multiextension filetypes, but I only know these two and Google isn't helpful. Can some of you help me out here? Should

D12544: Don't select file extension

ngraham added a comment. This is so nice! Let me test extensively... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

ngraham edited the summary of this revision. ngraham added a dependency: D12545: Set focus on the filename line edit when a file is selected. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

anemeth added a comment. In D12544#254419 , @ngraham wrote: > Why don't we do it here, since it's more related--or even in a separate patch, since now that I test without the patch, it seems that it's actually an unrelated pre-existing bug.

D12544: Don't select file extension

ngraham added a comment. Why don't we do it here, since it's more related--or even in a separate patch, since now that I test without the patch, it seems that it's actually an unrelated pre-existing bug. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth

D12544: Don't select file extension

anemeth added a comment. In D12544#254411 , @ngraham wrote: > Nice! But I notice that even though the correct part of the text is selected, the field doesn't actually receive focus. Well, that was (will be) included in D12538

D12544: Don't select file extension

ngraham added a comment. Nice! But I notice that even though the correct part of the text is selected, the field doesn't actually receive focus. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, brun

D12544: Don't select file extension

anemeth updated this revision to Diff 33162. anemeth added a comment. - Clarify comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12544?vs=33161&id=33162 BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D12544: Don't select file extension

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #fram

D12544: Don't select file extension

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kd